fix(p2p): fix update whitelist handler #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 85.22% 85.34% +0.11%
==========================================
Files 285 285
Lines 22368 22362 -6
Branches 3371 3369 -2
==========================================
+ Hits 19063 19084 +21
+ Misses 2631 2609 -22
+ Partials 674 669 -5 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
fix/update-whitelist
branch
3 times, most recently
from
80f6e73 to
7c333ea
Compare
glevco
force-pushed
the
fix/update-whitelist
branch
from
7c333ea to
2b048bd
Compare
msbrogli
requested changes
Jan 12, 2024
glevco
force-pushed
the
fix/update-whitelist
branch
from
2b048bd to
a37e5f3
Compare
msbrogli
previously approved these changes
Jan 15, 2024
jansegre
previously approved these changes
Jan 16, 2024
glevco
force-pushed
the
fix/update-whitelist
branch
3 times, most recently
from
32a8903 to
192c8b3
Compare
glevco
force-pushed
the
fix/update-whitelist
branch
from
70ab0d4 to
5150688
Compare
jansegre
approved these changes
Jan 17, 2024
msbrogli
approved these changes
Jan 18, 2024
glevco
force-pushed
the
fix/update-whitelist
branch
from
5150688 to
baecd84
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some Twisted errors that are logged raw, causing each log line to become an alert in OpsGenie, as in this incident: https://github.com/HathorNetwork/on-call-incidents/issues/153.
After some investigation, the reason for this is not 100% clear, but there are some suspicions. This PR attempts to fix at least one case that would cause the problem. We've tested a full node running on mainnet for a few days, and by inspecting its logs, it looks like the error has improved.
Acceptance Criteria
update_whitelist()to useDeferred.addTimeout().readBody()call to be included in the timeout.update_whitelist()so the errback is after the callback, so the errback handles exceptions from the callback.update_whitelist(), including cases for success, request error, and request timeout.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged